- name
- structured-pr-review
- description
- >
- argument-hint
- <PR-URL or number>
Structured PR Review
Two modes: giving reviews and addressing review comments. No external dependencies — uses gh CLI only.
Giving Reviews
When asked to review or check a PR:
- Fetch the PR details and full diff
- Walk through each review layer in order (see references/review-layers.md):
- Security — secrets, injection, auth, exposure - Correctness — logic errors, edge cases, error handling - Conventions — team standards (customize via references/conventions.md) - IaC — Terraform/CloudFormation checks (customize via references/iac-checklist.md) - Testing — coverage, new code has tests
- Produce a structured verdict with severity tiers
Key principles:
- Be direct — "this approach has problems" beats "interesting choice"
- Every issue includes what to fix, not just what's wrong
- Acknowledge what the PR does well
- When in doubt on severity, go one level lower
See references/review-layers.md for the full framework and verdict format.
Addressing Review Comments
When asked to address, fix, or respond to PR feedback:
- Fetch all review comments (inline + review-level)
- Fix each issue or document why not
- Reply to every comment — none left unacknowledged
- Resolve threads, update PR description, push
See references/addressing-workflow.md for the step-by-step workflow.
Key rules:
- Never leave comments unacknowledged — reply to every one
- Always update the PR description after making changes
- Verify the PR is actually merged before closing linked issues
Customization
This skill ships with generic review layers. Customize for your team:
- references/conventions.md — coding conventions, commit format, naming rules. Ships with common defaults — customize for your team.
- references/iac-checklist.md — add your IaC-specific checks (required tags, allowed regions, provider pins). Ships with common Terraform patterns — extend for your org.
References
- references/review-layers.md — review framework, severity tiers, verdict format
- references/addressing-workflow.md — comment handling, thread resolution
- references/conventions.md — your team's conventions (customizable)
- references/iac-checklist.md — IaC review checklist (customizable)
Works Well With
- terraform-skill (antonbabenko) — Terraform authoring best practices, module patterns, testing strategies
- conventional-commits — commit message format conventions (useful when addressing reviews)
- github (built-in) — general
ghCLI operations for PRs, issues, and CI runs - gh-issues (built-in) — automated PR monitoring and review spawning